fix(replica clusters): apply hot-standby parameter changes#9952
Merged
leonardoce merged 4 commits intomainfrom Feb 19, 2026
Merged
fix(replica clusters): apply hot-standby parameter changes#9952leonardoce merged 4 commits intomainfrom
leonardoce merged 4 commits intomainfrom
Conversation
dosubot
bot
added
the
size:L
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Member
Author
|
/test |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/21873041523 |
armru
requested review from
NiccoloFei,
jsilvela and
litaocdl
as code owners
Member
Author
|
/test |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/21874015283 |
armru
force-pushed
the
dev/replica-update
branch
from
fd0bb6e to
ac6a1ca
Compare
gbartolini
force-pushed
the
dev/replica-update
branch
from
ac6a1ca to
9a1c0b2
Compare
gbartolini
changed the title
gbartolini
approved these changes
Feb 16, 2026
leonardoce
force-pushed
the
dev/replica-update
branch
from
accc3b1 to
f56ef91
Compare
In replica clusters, decreasing hot-standby sensitive parameters (e.g., max_connections) never triggered a restart because: 1. pg_controldata values come from the external source primary via WAL, not from the local cluster's designated primary, making the pg_controldata comparison permanently unsatisfiable for replicas. 2. The designated primary was not recognized as "primary-like" for restart purposes since IsPrimary is always false in replica clusters. Skip the pg_controldata check for replica clusters and treat the designated primary as primary-like for in-place restart triggering. Closes #9855 Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
leonardoce
force-pushed
the
dev/replica-update
branch
from
f56ef91 to
bbd3dcc
Compare
leonardoce
approved these changes
Feb 19, 2026
leonardoce
pushed a commit
that referenced
this pull request
Feb 19, 2026
In replica clusters, decreasing hot-standby sensitive parameters (e.g., max_connections) never triggered a restart because: 1. pg_controldata values come from the external source primary via WAL, not from the local cluster's designated primary, making the pg_controldata comparison permanently unsatisfiable for replicas. 2. The designated primary was not recognized as "primary-like" for restart purposes since IsPrimary is always false in replica clusters. Skip the pg_controldata check for replica clusters and treat the designated primary as primary-like for in-place restart triggering. Closes #9855 Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Gabriele Bartolini <[email protected]> Co-authored-by: Gabriele Bartolini <[email protected]> (cherry picked from commit dfd8518)
leonardoce
pushed a commit
that referenced
this pull request
Feb 19, 2026
In replica clusters, decreasing hot-standby sensitive parameters (e.g., max_connections) never triggered a restart because: 1. pg_controldata values come from the external source primary via WAL, not from the local cluster's designated primary, making the pg_controldata comparison permanently unsatisfiable for replicas. 2. The designated primary was not recognized as "primary-like" for restart purposes since IsPrimary is always false in replica clusters. Skip the pg_controldata check for replica clusters and treat the designated primary as primary-like for in-place restart triggering. Closes #9855 Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Gabriele Bartolini <[email protected]> Co-authored-by: Gabriele Bartolini <[email protected]> (cherry picked from commit dfd8518) (cherry picked from commit 014a478)
leonardoce
pushed a commit
that referenced
this pull request
Feb 19, 2026
In replica clusters, decreasing hot-standby sensitive parameters (e.g., max_connections) never triggered a restart because: 1. pg_controldata values come from the external source primary via WAL, not from the local cluster's designated primary, making the pg_controldata comparison permanently unsatisfiable for replicas. 2. The designated primary was not recognized as "primary-like" for restart purposes since IsPrimary is always false in replica clusters. Skip the pg_controldata check for replica clusters and treat the designated primary as primary-like for in-place restart triggering. Closes #9855 Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Gabriele Bartolini <[email protected]> Co-authored-by: Gabriele Bartolini <[email protected]> (cherry picked from commit dfd8518) (cherry picked from commit 014a478) (cherry picked from commit d82e589)
mnencia
pushed a commit
that referenced
this pull request
Feb 20, 2026
In replica clusters, decreasing hot-standby sensitive parameters (e.g., max_connections) never triggered a restart because: 1. pg_controldata values come from the external source primary via WAL, not from the local cluster's designated primary, making the pg_controldata comparison permanently unsatisfiable for replicas. 2. The designated primary was not recognized as "primary-like" for restart purposes since IsPrimary is always false in replica clusters. Skip the pg_controldata check for replica clusters and treat the designated primary as primary-like for in-place restart triggering. Closes #9855 Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Gabriele Bartolini <[email protected]> Co-authored-by: Gabriele Bartolini <[email protected]> (cherry picked from commit dfd8518) (cherry picked from commit 014a478) (cherry picked from commit d82e589)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In replica clusters, decreasing hot-standby sensitive parameters (e.g., max_connections) never triggered a restart because:
pg_controldata values come from the external source primary via WAL, not from the local cluster's designated primary, making the pg_controldata comparison permanently unsatisfiable for replicas.
The designated primary was not recognized as "primary-like" for restart purposes since IsPrimary is always false in replica clusters.
Skip the pg_controldata check for replica clusters and treat the designated primary as primary-like for in-place restart triggering.
Closes #9855