Conversation
dosubot
bot
added
the
size:S
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
jsilvela
changed the title
jsilvela
changed the title
jsilvela
changed the title
Collaborator
Author
|
/test depth=push |
Contributor
|
@jsilvela, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/21954653320 |
dosubot
bot
added
size:L
Member
|
/test |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/22058441399 |
armru
approved these changes
Feb 19, 2026
Signed-off-by: Jaime Silvela <[email protected]>
…promotion Move the IsPrimary() check from Start() startup into the goroutine's per-trigger loop. The previous one-time startup check blocked the synchronizer permanently after an in-place promotion (pg_promote does not restart the pod), preventing role reconciliation on the newly promoted instance and leaking goroutines from TriggerRoleSynchronizer calls on the unbuffered channel. The goroutine now always runs but skips reconciliation on non-primary instances, correctly handling both the original issue (no role writes on replicas/designated primaries) and subsequent promotions. Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Marco Nenciarini <[email protected]>
mnencia
approved these changes
Feb 22, 2026
Member
|
/test |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/22278433595 |
mnencia
changed the title
mnencia
added
bug 🐛
Member
|
/ok-to-merge |
|
Related Documentation Checked 0 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
cnpg-bot
pushed a commit
that referenced
this pull request
Feb 22, 2026
Move the IsPrimary() check from a one-time evaluation at startup into the reconciliation loop so that replicas and designated primaries skip role writes, and a promoted instance starts reconciling without requiring a pod restart. Closes #9800 Signed-off-by: Jaime Silvela <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Marco Nenciarini <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> Co-authored-by: Marco Nenciarini <[email protected]> (cherry picked from commit 24225c6)
cnpg-bot
pushed a commit
that referenced
this pull request
Feb 22, 2026
Move the IsPrimary() check from a one-time evaluation at startup into the reconciliation loop so that replicas and designated primaries skip role writes, and a promoted instance starts reconciling without requiring a pod restart. Closes #9800 Signed-off-by: Jaime Silvela <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Marco Nenciarini <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> Co-authored-by: Marco Nenciarini <[email protected]> (cherry picked from commit 24225c6)
mnencia
added a commit
that referenced
this pull request
Feb 22, 2026
Move the IsPrimary() check from a one-time evaluation at startup into the reconciliation loop so that replicas and designated primaries skip role writes, and a promoted instance starts reconciling without requiring a pod restart. Closes #9800 Signed-off-by: Jaime Silvela <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Marco Nenciarini <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> Co-authored-by: Marco Nenciarini <[email protected]> (cherry picked from commit 24225c6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the IsPrimary() check from a one-time evaluation at startup into
the reconciliation loop so that replicas and designated primaries skip
role writes, and a promoted instance starts reconciling without
requiring a pod restart.
Closes #9800