Description

Fixes a bug where only the first plugin with ReconcilerHooks capability is executed during cluster/backup reconciliation. When a plugin returns BEHAVIOR_CONTINUE,
the reconciler loop returns immediately instead of continuing to process remaining plugins.

It is not clear that there is another type of reconciler.ReconcilerHooksResult that should be returned to allow processing of subsequent plugins, unless plugins are expected to use ReconcilerHooksResult_BEHAVIOR_UNSPECIFIED, but this seems inconsistent with the documentation.

Root Cause

In internal/cnpi/plugin/client/reconciler.go, the reconcilerHook function's switch statement for BEHAVIOR_CONTINUE returns immediately:

case reconciler.ReconcilerHooksResult_BEHAVIOR_CONTINUE:
    return newContinueResult(plugin.Name()) 

This breaks what I suspect is the intended behavior based on this definition

	// BEHAVIOR_CONTINUE indicates that this reconciliation loop will
	// proceed running.
	// BEHAVIOR_CONTINUE is useful when the plugin executes changes on internal status or resources not directly managed
	// by the main reconciliation loop

where I would imagine BEHAVIOR_CONTINUE should allow the loop to proceed to the next plugin before continuing with the operator's core reconciliation.

Solution

Changed the BEHAVIOR_CONTINUE case to continue the loop instead of returning:

  case reconciler.ReconcilerHooksResult_BEHAVIOR_CONTINUE:
      // Continue to next plugin

Now all plugins that return the BEHAVIOR_CONTINUE cause the reconciler hook to iterate to the next plugin.

Testing

Deployed a cluster with two plugins:

1. barman-cloud.cloudnative-pg.io (index 0)
2. modified local version of https://github.com/cloudnative-pg/cnpg-i-hello-world that implemented the reconciler interface (index 1)

Before Fix

The reconciler Pre hook on the second plugin (index 1) never executed

After Fix

The reconciler Pre hook for both plugins executed

Impact

I tested this with the latest version of the operator as of the time of the creation of this ticket at 1bf4584. The logic skipping plugins seems to present ever since internal/cnpi/plugin/client/reconciler.go was introduced a couple years ago and looks to be in v1.28x and v1.27.x.

Assisted-by: Claude Opus 4.6