feat(args): adding 'stdout' flag#129
Merged
cococonscious merged 3 commits intocococonscious:mainfrom Jan 21, 2025
Merged
Conversation
Added a '--stdout' flag to output the message to stdout instead of continuing on with the git workflow. Allows koji to be used with non-git workflows.
The "stdout" does nothing in hook mode. Ensuring they are not called together.
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
cococonscious
requested changes
Jan 21, 2025
Owner
cococonscious
left a comment
cococonscious
left a comment
There was a problem hiding this comment.
Hi Jonathan, thanks for your PR!
Please add two integration tests for the argument, one checking for success, the other for checking that it conflicts with all and hook correctly. Otherwise LGTM.
added tests checking for success as well as '--hook' and '--all' exclusion.
cococonscious
approved these changes
Jan 21, 2025
Merged
cococonscious
pushed a commit
that referenced
this pull request
Jan 21, 2025
## 🤖 New release * `koji`: 3.1.0 -> 3.2.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [3.2.0](v3.1.0...v3.2.0) - 2025-01-21 ### Added - *(args)* adding 'stdout' flag (#129) ### Changed - *(deps)* update rust crate dirs to v6 (#132) - update all non-major dependencies (#130) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a '--stdout' flag to output the message to stdout instead of continuing on with the git workflow. Allows koji to be used with non-git workflows.