fix: xdg crate not supporting windows#159
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a cross-platform compatibility issue where the xdg crate (which is Unix-specific) was being unconditionally imported and used, causing compilation failures on Windows. The fix adds conditional compilation attributes to restrict the xdg import and usage to Unix and Redox systems only, and updates the documentation to clarify platform-specific configuration paths.
- Adds conditional compilation directives to restrict
xdg::BaseDirectoriesto Unix/Redox platforms - Updates README to document Windows-specific configuration path (
%USERPROFILE%\AppData\Roaming\koji\config.toml)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/config.rs | Adds #[cfg(any(unix, target_os = "redox"))] attributes to conditionally compile xdg imports and usage |
| README.md | Documents platform-specific configuration file paths for Unix/Redox vs Windows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
## 🤖 New release * `koji`: 3.3.0 -> 3.3.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [3.3.1](v3.3.0...v3.3.1) - 2025-11-30 ### Fixed - xdg crate not supporting windows ([#159](#159)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fixes the failing Windows builds when releasing