Make the Xpp3Reader#read(XmlPullParser, boolean strict) public#196
Merged
michael-o merged 1 commit intocodehaus-plexus:masterfrom Mar 15, 2022
Merged
Make the Xpp3Reader#read(XmlPullParser, boolean strict) public#196michael-o merged 1 commit intocodehaus-plexus:masterfrom
michael-o merged 1 commit intocodehaus-plexus:masterfrom
Conversation
hboutemy
approved these changes
Mar 15, 2022
Member
hboutemy
left a comment
hboutemy
left a comment
There was a problem hiding this comment.
uh, how did we let this in that state for so many years?
thanks for the new eyes :)
hboutemy
changed the title
Member
Author
No, that's not very old. It's coming from the build/consumer feature, and more specifically, my refactoring to use pull parsing instead of sax. |
michael-o
approved these changes
Mar 15, 2022
Member
Author
|
Thx for the approvals. However I have no karma on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would avoid using reflection in maven-model-builder:
https://github.com/apache/maven/blob/master/maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java#L178-L203