replace handwritten components.xml with annotations#285
Merged
Conversation
![sonatype-lift[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
modello-core/src/main/java/org/codehaus/modello/plugin/model/ModelMetadataPlugin.java
Show resolved
Hide resolved
hboutemy
force-pushed
the
annotations
branch
from
a9ab27c to
036ff74
Compare
Contributor
|
Are there technical reasons why a migration towards Sisu components is not possible or is it just to reduce implementation effort for the first step? |
Member
Author
|
I tried to go directly with JSR-330 and Sisu, but unit tests failed: there is probably some upgrades to do that i don't precisely know |
hboutemy
changed the title
modello-core/src/main/java/org/codehaus/modello/core/DefaultMetadataPluginManager.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #275
required a few compromises:
pluginsparameter from parent class has different rolesbut it's already a great improvement to see declaration as annotations