Fix XSD generator to respect required field attribute#528
Merged
slachiewicz merged 4 commits intomasterfrom Nov 3, 2025
Merged
Fix XSD generator to respect required field attribute#528slachiewicz merged 4 commits intomasterfrom
slachiewicz merged 4 commits intomasterfrom
Conversation
- Modified XsdGenerator to respect field.isRequired() directly instead of depending on enforceMandatoryElements parameter - Removed required=true from type field in modello.mdo since type is optional when association is present - Required fields now correctly omit minOccurs="0" in generated XSD, making them mandatory Co-authored-by: slachiewicz <[email protected]>
…ments parameter Co-authored-by: slachiewicz <[email protected]>
Copilot
AI
changed the title
[WIP] Fix required attribute not being taken into account
Fix XSD generator to respect required field attribute
Oct 26, 2025
slachiewicz
approved these changes
Oct 26, 2025
Member
|
@copilot can you add a unit test for such change? |
…ATORY_ELEMENTS parameter - Created RequiredFieldXsdGeneratorTest to verify required fields are enforced by default - Added required-field.mdo test model with both required and optional fields - Test validates that XML missing required fields fails validation - Test validates that XML with required fields passes validation Co-authored-by: slawekjaranowski <[email protected]>
Contributor
Author
Added
Commit: 449af72 |
slachiewicz
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XSD generator was ignoring
<required>true</required>in model definitions, generatingminOccurs="0"(optional) for all fields unless an undocumented parameter was set.Changes
XsdGenerator.java
enforceMandatoryElementsparameter - now respectsfield.isRequired()directlyminOccurs="0", making them mandatory in XSD validationmodello.mdo
<required>true</required>from ModelField'stypefieldassociationelement is presentTest Added
RequiredFieldXsdGeneratorTestto verify required fields are enforced without theXSD_ENFORCE_MANDATORY_ELEMENTSparameterExample
Model definition:
Before:
After:
Fixes #ARCHETYPE-684
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.