Use a CachingOutputStream when using the build context#64
Use a CachingOutputStream when using the build context#64gnodet merged 1 commit intocodehaus-plexus:masterfrom
Conversation
|
@gnodet can you explain what will be the advantage here? |
It provides caching. The output file is not modified unless there's an actual change in the content. |
|
Maybe you can adjust the commit message to explain this as it is not really obvious (for me) so one can read about it later on. I must confess the name is a bit confusing because one usually more have caching for reading data. |
Done |
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
Looks good, but keep in mind that as of today no one is using the "new" build API here so a release might not have any impact on existing users.
Yes, PRs will follow... |
This won't help as this will instantly break the plugin, first m2e needs to add support for the new plexus-build API ... |
Plugins won't be broken, I think it's only the incremental build inside m2e which will be broken, and most probably, not really broken, but running sub-optimally (i.e. will rebuild more than needed) until m2e is update to support both. |
Well that's the purpose of the build-api if that is not working the plugin is (from user POV) broken... |
The CachingOutputStream provides a write cache so that the target file is only modified if there's a content change. If the data written exactly maps the existing content of the file, the file will not be modified at all.
3 participants
No description provided.