Respect CompilerConfiguration.sourceFiles in EclipseJavaCompiler#233
Merged
olamy merged 1 commit intocodehaus-plexus:masterfrom Jul 15, 2022
Merged
Respect CompilerConfiguration.sourceFiles in EclipseJavaCompiler#233olamy merged 1 commit intocodehaus-plexus:masterfrom
olamy merged 1 commit intocodehaus-plexus:masterfrom
Conversation
famod
commented
Jul 14, 2022
| addExtraSources( extraDir, allSources ); | ||
| } | ||
| } | ||
| List<String> allSources = Arrays.asList( getSourceFiles( config ) ); |
Contributor
Author
There was a problem hiding this comment.
So we are back to a list; I basically rolled back #230 because it doesn't make sense anymore.
Just like JavacCompiler does, to avoid "FilerException: Source file already created" during annotation processing when running mvn without clean after changing code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like JavacCompiler does, to avoid "FilerException: Source file already created" during annotation processing when running mvn without clean after changing code.
Fixes #232
The crucial thing here is that the compiler will run the annotation processors anyway, so it makes no sense to explicitly specify sources generated from the previous run.
Without the change to
EclipseJavaCompilerthe new IT would fail with:(sorry for the garbled output but that's the way it's printed out by compiler-plugin)