Conversation
To figure out presence of component, and if construction fails, report some sane(r) message tham obvious false information: "compiler not present".
|
Sisu in general is fully lazy: see https://eclipse.github.io/sisu.inject/apidocs/reference/org/eclipse/sisu/BeanEntry.html The Doing |
| // presence of provider means component is present (but not yet constructed) | ||
| Provider<Compiler> compiler = compilers.get(compilerId); | ||
|
|
||
| // it exists: as provider is found |
There was a problem hiding this comment.
Should that not mean that it is NOT there if it is null?
There was a problem hiding this comment.
yes, yes, bad worded comments but i hope the intent is clear 😄
There was a problem hiding this comment.
Maybe remove or move down into the if case (code speaks for itself?)
To figure out presence of component,
and if construction fails, report some
sane(r) message tham obvious false
information: "compiler not present".