Fixed regressions: #163 and #194#195
Merged
michael-o merged 1 commit intocodehaus-plexus:masterfrom Apr 16, 2022
Merged
Conversation
Contributor
belingueres
commented
Apr 5, 2022
belingueres
commented
- Regression: encoding error when parsing a ISO-8859-1 pom with Maven Resolver #163 - new case: Don't assume UTF8 as default, to allow parsing from String.
- Incorrect getText() after parsing the DOCDECL section #194 - Incorrect getText() after parsing the DOCDECL section.
![sonatype-lift[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
belingueres
force-pushed
the
ISSUE-194-AND-163
branch
from
5ff5d58 to
48e6445
Compare
belingueres
force-pushed
the
ISSUE-194-AND-163
branch
from
48e6445 to
9dc1610
Compare
* codehaus-plexus#163 - new case: Don't assume UTF8 as default, to allow parsing from String. * codehaus-plexus#194 - Incorrect getText() after parsing the DOCDECL section. * Added tests exercising other regressions exposed while fixing this issues.
belingueres
force-pushed
the
ISSUE-194-AND-163
branch
from
9dc1610 to
55678b0
Compare
Contributor
Author
|
@michael-o Thanks for merging this PR. Unfortunately two of the test files where commited with the wrong git core.autocrlf setting, losing the intended CRLF line endings: |
Member
|
Please provide a followup PR with gitattributes for these files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.