V3 changes to make external usage easier#277
Merged
slachiewicz merged 4 commits intocodehaus-plexus:plexus-utils-3.xfrom Nov 6, 2024
Merged
V3 changes to make external usage easier#277slachiewicz merged 4 commits intocodehaus-plexus:plexus-utils-3.xfrom
slachiewicz merged 4 commits intocodehaus-plexus:plexus-utils-3.xfrom
Conversation
Contributor
Author
|
@slachiewicz if we can get these enhancements in Apache Rat can go back to using this library rather than carrying our own implementations. Your assistance is appreciated. |
Member
|
Would You be able to add some tests? |
Contributor
Author
|
Absolutely. I will work on them today, when I get time from my actual work. |
Contributor
Author
|
I added the tests and think I found a but as noted in #279 If there is agreement that is a bug, I can fix it as part of this and PR 278 |
Contributor
Author
|
@slachiewicz I have added tests to both the V3 and V4 pull requests as well as fixes for #279 |
slachiewicz
approved these changes
Nov 5, 2024
Member
|
I'm not sure if we need maintain 3.x version |
Contributor
Author
|
I believe that it is still used in Maven 3.x
…On Tue, Nov 5, 2024 at 1:17 PM Slawomir Jaranowski ***@***.***> wrote:
I'm not sure if we need maintain 3.x version
—
Reply to this email directly, view it on GitHub
<#277 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASTVHQIQKBFUHR4LHX7RKLZ7DAONAVCNFSM6AAAAABQHMRRAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJXGE2TGNJSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
LinkedIn: http://www.linkedin.com/in/claudewarren
|
Member
|
that shouldn't be a problem - I can release 4.x and 3.x |
slawekjaranowski
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #276 and #279 on V3
This change: