Merged
Conversation
belingueres
reviewed
Dec 7, 2019
| public void testCombineKeys() | ||
| throws Exception | ||
| { | ||
| String lhs = "<props>" + "<property combine.keys='name'><name>LHS-ONLY</name><value>LHS</value></property>" |
Contributor
There was a problem hiding this comment.
is this ok? according to the readme in https://github.com/atteo/xml-combiner, the value of combine.keys are attributes names, and here are tag names.
Member
Author
There was a problem hiding this comment.
Hmm, I see what you mean. In case of Maven I am missing the ability to identity the key of complex objects.
But there's indeed something else wrong: combine.keys shõuld not be on the element itself, but the wrapping element. And with that I understand why it is for attributes. I need to have another look at it.
Great catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.