fix: Use requests byte payload in messages interceptor#185
Merged
Conversation
dannykopping
approved these changes
Feb 19, 2026
Collaborator
dannykopping
left a comment
dannykopping
left a comment
There was a problem hiding this comment.
LGTM except for one perf-related change.
| path := strings.TrimPrefix(r.URL.Path, p.RoutePrefix()) | ||
| switch path { | ||
| case routeMessages: | ||
| payload, err := io.ReadAll(r.Body) |
Collaborator
There was a problem hiding this comment.
We should stick with json.NewDecoder; it's more memory-efficient.
Contributor
Author
This was referenced Feb 23, 2026
f0ssel
pushed a commit
to coder/coder
that referenced
this pull request
Feb 23, 2026
Backports #22264 Includes fixes coder/aibridge#189 and coder/aibridge#185 Signed-off-by: Danny Kopping <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
WithRequestBodyoption use to messages interceptor.Any structured request modifications are mirrored on original request payload.
Fixes missing adaptive thinking from request after re-marshaling due to golang SDK not supporting it.
Fixes: #177