Merged
Conversation
|
I cloned and tried to build -- do you know what I might be missing? yarn build v0.24.6
(node:13301) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
$ ./ci/build/build-code-server.sh
src/node/app/vscode.ts:15:8 - error TS2307: Cannot find module '../../../lib/vscode/src/vs/server/ipc' or its corresponding type declarations.
15 } from "../../../lib/vscode/src/vs/server/ipc"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/node/cli.ts:6:32 - error TS2307: Cannot find module '../../lib/vscode/src/vs/server/ipc' or its corresponding type declarations.
6 import { Args as VsArgs } from "../../lib/vscode/src/vs/server/ipc"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/node/cli.ts:123:3 - error TS2322: Type '{ auth: { type: typeof AuthType; description: string; }; password: { type: "string"; description: string; }; cert: { type: typeof OptionalString; path: true; description: string; }; "cert-key": { ...; }; ... 27 more ...; verbose: { ...; }; }' is not assignable to type 'Options<Required<Args>>'.
Object literal may only specify known properties, and '"user-data-dir"' does not exist in type 'Options<Required<Args>>'.
123 "user-data-dir": { type: "string", path: true, description: "Path to the user data directory." },
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/node/cli.ts:292:12 - error TS2339: Property 'verbose' does not exist on type 'Args'.
292 if (args.verbose) {
~~~~~~~
src/node/cli.ts:309:12 - error TS2339: Property 'verbose' does not exist on type 'Args'.
309 args.verbose = true
~~~~~~~
src/node/cli.ts:313:12 - error TS2339: Property 'verbose' does not exist on type 'Args'.
313 args.verbose = false
~~~~~~~
src/node/cli.ts:317:12 - error TS2339: Property 'verbose' does not exist on type 'Args'.
317 args.verbose = false
~~~~~~~
src/node/cli.ts:321:12 - error TS2339: Property 'verbose' does not exist on type 'Args'.
321 args.verbose = false
~~~~~~~
src/node/cli.ts:325:12 - error TS2339: Property 'verbose' does not exist on type 'Args'.
325 args.verbose = false
~~~~~~~
src/node/cli.ts:335:8 - error TS7053: Element implicitly has an 'any' type because expression of type '"user-data-dir"' can't be used to index type 'Args'.
Property 'user-data-dir' does not exist on type 'Args'.
335 if (!args["user-data-dir"]) {
~~~~~~~~~~~~~~~~~~~~~
src/node/cli.ts:337:5 - error TS7053: Element implicitly has an 'any' type because expression of type '"user-data-dir"' can't be used to index type 'Args'.
Property 'user-data-dir' does not exist on type 'Args'.
337 args["user-data-dir"] = paths.data
~~~~~~~~~~~~~~~~~~~~~
src/node/cli.ts:340:8 - error TS7053: Element implicitly has an 'any' type because expression of type '"extensions-dir"' can't be used to index type 'Args'.
Property 'extensions-dir' does not exist on type 'Args'.
340 if (!args["extensions-dir"]) {
~~~~~~~~~~~~~~~~~~~~~~
src/node/cli.ts:341:5 - error TS7053: Element implicitly has an 'any' type because expression of type '"extensions-dir"' can't be used to index type 'Args'.
Property 'extensions-dir' does not exist on type 'Args'.
341 args["extensions-dir"] = path.join(args["user-data-dir"], "extensions")
~~~~~~~~~~~~~~~~~~~~~~
src/node/cli.ts:341:40 - error TS7053: Element implicitly has an 'any' type because expression of type '"user-data-dir"' can't be used to index type 'Args'.
Property 'user-data-dir' does not exist on type 'Args'.
341 args["extensions-dir"] = path.join(args["user-data-dir"], "extensions")
~~~~~~~~~~~~~~~~~~~~~
src/node/entry.ts:6:49 - error TS2307: Cannot find module '../../lib/vscode/src/vs/server/ipc' or its corresponding type declarations.
6 import { CliMessage, OpenCommandPipeArgs } from "../../lib/vscode/src/vs/server/ipc"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/node/entry.ts:45:48 - error TS7053: Element implicitly has an 'any' type because expression of type '"user-data-dir"' can't be used to index type 'Args'.
Property 'user-data-dir' does not exist on type 'Args'.
45 logger.info(`Using user-data-dir ${humanPath(args["user-data-dir"])}`)
~~~~~~~~~~~~~~~~~~~~~
src/node/entry.ts:47:50 - error TS7053: Element implicitly has an 'any' type because expression of type '"extensions-dir"' can't be used to index type 'Args'.
Property 'extensions-dir' does not exist on type 'Args'.
47 logger.trace(`Using extensions-dir ${humanPath(args["extensions-dir"])}`)
~~~~~~~~~~~~~~~~~~~~~~
Found 17 errors.
error Command failed with exit code 2.
nv:code-server Pavlovcik$ |
Member
Author
|
It looks like the patch wasn't applied. Check out https://github.com/cdr/code-server/blob/v3.5.0/doc/CONTRIBUTING.md#build. In particular the |
|
Hi, I got the same error and was after |
Oh, figure out, basically I did Works well, and I confirm fixed the issue on iPad. |
Member
Author
|
Thank you for testing it!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't have to make any changes except add a new file to the
coder.jsbuild script.Might fix #1015 but I don't have any means of testing it.