fix: stop spamming DERP map updates for equivalent maps#11792
Merged
spikecurtis merged 1 commit intomainfrom Jan 24, 2024
Merged
fix: stop spamming DERP map updates for equivalent maps#11792spikecurtis merged 1 commit intomainfrom
spikecurtis merged 1 commit intomainfrom
Conversation
This was referenced Jan 24, 2024
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
mtojek
approved these changes
Jan 24, 2024
Member
mtojek
left a comment
There was a problem hiding this comment.
Syntactically correct, but I'm not super familiar with the tailnet code internals. Thanks for addressing the issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes 2 related issues:
tailcfg.DERPMap. This also has the effect of reducing the number of times we convert to and from protobuf.