chore: deprecate gauge metrics with _total suffix (#12744)#12976
Merged
matifali merged 3 commits intocoder:mainfrom Apr 24, 2024
Merged
chore: deprecate gauge metrics with _total suffix (#12744)#12976matifali merged 3 commits intocoder:mainfrom
matifali merged 3 commits intocoder:mainfrom
Conversation
cdr-bot
bot
added
the
community
Deprecated metrics: - coderd_oauth2_external_requests_rate_limit_total - coderd_api_workspace_latest_build_total
snark87
force-pushed
the
deprecated-metrics
branch
from
98577e5 to
ae1b62c
Compare
dannykopping
approved these changes
Apr 18, 2024
Contributor
dannykopping
left a comment
dannykopping
left a comment
There was a problem hiding this comment.
Great work @snark87! Thank you very much for your contribution
johnstcn
approved these changes
Apr 18, 2024
Member
johnstcn
left a comment
johnstcn
left a comment
There was a problem hiding this comment.
Nice work! Created a follow-up issue to track deprecation.
Member
|
@snark87 can you please merge latest main? There's an issue with one of the tests that has been worked around here: coder/internal#101 |
add link to follow-up issue Co-authored-by: Cian Johnston <[email protected]>
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12744
Deprecated metrics: