Conversation
johnstcn
changed the title
johnstcn
changed the title
johnstcn
force-pushed
the
cj/prebuild-template-upgrade
branch
from
42420b1 to
fa2d4eb
Compare
johnstcn
added
the
release/breaking
dannykopping
left a comment
dannykopping
left a comment
There was a problem hiding this comment.
No notes, awesome work @johnstcn 💪
This reverts commit c33f9b9.
johnstcn
force-pushed
the
cj/prebuild-template-upgrade
branch
from
ce577e1 to
da8bd12
Compare
|
|
||
| // TransitionWorkspace is a convenience method for transitioning a workspace from one state to another. | ||
| func MustTransitionWorkspace(t testing.TB, client *codersdk.Client, workspaceID uuid.UUID, from, to database.WorkspaceTransition, muts ...func(req *codersdk.CreateWorkspaceBuildRequest)) codersdk.Workspace { | ||
| func MustTransitionWorkspace(t testing.TB, client *codersdk.Client, workspaceID uuid.UUID, from, to codersdk.WorkspaceTransition, muts ...func(req *codersdk.CreateWorkspaceBuildRequest)) codersdk.Workspace { |
There was a problem hiding this comment.
review: This is annoying to have as a database type, so migrated to use the codersdk type instead. This inflated the diff a bit but removes an unnecessary conversion.
aslilac
left a comment
aslilac
left a comment
There was a problem hiding this comment.
The react code looks good
I took a bit of a closer look this time tho, and I'm wondering if this should be handled by the backend rather than the clients? The CLI and the frontend are now both responsible for producing this behavior correctly, and I worry about them getting out of sync or needing to add this in even more places, like the VSCode extension or the JetBrains plugin.
| throw new MissingBuildParameters(missingParameters, activeVersionId); | ||
| } | ||
|
|
||
| // Stop the workspace if it is already running. |
There was a problem hiding this comment.
hmm. I'm a bit worried about adding this directly inside the API method. most everything in here is 1:1 with a backend endpoint, occasionally with minimal logic to convert from an options object to a query string or whatever. but this is actual application logic leaking in here.
Yeah, that's a valid concern. The main difficulty there is that there's no 'restart' transition in our current workspace transition model. Ideally we would have something like a 'restart' type provisioner job that would handle both the stop and start stages (or maybe perform a stop and enqueue a start build upon completion). I'd like us to do that eventually as it would greatly simplify the whole implementation here and let us model both restart and update as the same kind of state transition. Would you be OK with making this a follow-up item in the interest of expediency? |
I vote for later, but soon™️ |
|
yeah, that sounds like a good follow up solution 👍 |
3 participants
Fixes #17840
NOTE: calling this out as a breaking change so that it is highly visible in the changelog.
coder updateto stop the workspace if already running.