feat(provisioner): associate resources with coder_devcontainer#21602
Merged
DanielleMaywood merged 6 commits intomainfrom Jan 29, 2026
Merged
feat(provisioner): associate resources with coder_devcontainer#21602DanielleMaywood merged 6 commits intomainfrom
coder_devcontainer#21602DanielleMaywood merged 6 commits intomainfrom
Conversation
DanielleMaywood
force-pushed
the
danielle/devcontainer-resources/provisioner
branch
4 times, most recently
from
3fb3fe6 to
6d2900e
Compare
DanielleMaywood
force-pushed
the
danielle/devcontainer-resources/provisioner
branch
from
6d2900e to
68c3ab5
Compare
johnstcn
reviewed
Jan 21, 2026
Comment on lines
+1194
to
+1216
| func dependsOnDevcontainer(graph *gographviz.Graph, dc *proto.Devcontainer, resourceAgentID string, resource *tfjson.StateResource) bool { | ||
| // Plan: we need to find if there is an edge between the resource and the devcontainer. | ||
| if dc.SubagentId == "" && resourceAgentID == "" { | ||
| resourceNodeSuffix := fmt.Sprintf(`] %s.%s (expand)"`, resource.Type, resource.Name) | ||
| agentNodeSuffix := fmt.Sprintf(`] coder_devcontainer.%s (expand)"`, dc.Name) | ||
|
|
||
| // Traverse the graph to check if the coder_<resource_type> depends on coder_devcontainer. | ||
| for _, dst := range graph.Edges.SrcToDsts { | ||
| for _, edges := range dst { | ||
| for _, edge := range edges { | ||
| if strings.HasSuffix(edge.Src, resourceNodeSuffix) && | ||
| strings.HasSuffix(edge.Dst, agentNodeSuffix) { | ||
| return true | ||
| } | ||
| } | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| // Provision: subagent ID and child resource ID are present | ||
| return dc.SubagentId == resourceAgentID | ||
| } |
Member
There was a problem hiding this comment.
(nit, non-blocking): Could refactor alongside dependsOnAgent given that there are minimal differences between the two functions. Maybe not worth it yet though, so omakase.
Contributor
Author
There was a problem hiding this comment.
We could do the following:
Introduce a new function resourceDependsOn
// resourceDependsOn checks if a resource depends on a target entity (agent or devcontainer).
// During Plan phase (when IDs aren't available), it uses graph edge analysis.
// During Provision phase (when IDs are present), it compares IDs directly.
func resourceDependsOn(graph *gographviz.Graph, resource *tfjson.StateResource, resourceTargetID, targetType, targetName, targetID string) bool {
// Provision: IDs available, compare directly
if targetID != "" || resourceTargetID != "" {
return targetID == resourceTargetID
}
// Plan: IDs not yet available, check graph edges
resourceNodeSuffix := fmt.Sprintf(`] %s.%s (expand)"`, resource.Type, resource.Name)
targetNodeSuffix := fmt.Sprintf(`] %s.%s (expand)"`, targetType, targetName)
for _, dst := range graph.Edges.SrcToDsts {
for _, edges := range dst {
for _, edge := range edges {
if strings.HasSuffix(edge.Src, resourceNodeSuffix) &&
strings.HasSuffix(edge.Dst, targetNodeSuffix) {
return true
}
}
}
}
return false
}As well as some constants
// Terraform resource type constants for the Coder provider.
const (
tfCoderAgent = "coder_agent"
tfCoderDevcontainer = "coder_devcontainer"
...
)And then the callsites could look like
resourceDependsOn(graph, resource, attrs.AgentID, tfCoderAgent, agent.Name, agent.Id)resourceDependsOn(graph, resource, attrs.AgentID, tfCoderDevcontainer, dc.Name, dc.SubagentId)
Member
There was a problem hiding this comment.
Yeah, I was thinking along those lines. Doesn't necessarily have to be in this PR though.
Contributor
Author
There was a problem hiding this comment.
Will do it in a follow-up PR then
johnstcn
reviewed
Jan 22, 2026
Contributor
Documentation CheckUpdates Needed
The note should be updated to reflect that these resources CAN now be attached to dev containers when using the Automated review via Coder Tasks |
johnstcn
approved these changes
Jan 27, 2026
mafredri
approved these changes
Jan 28, 2026
Contributor
Documentation CheckUpdates Needed
New Documentation Needed
Example pattern to document: resource "coder_devcontainer" "dev" {
agent_id = coder_agent.main.id
workspace_folder = "/workspace"
}
resource "coder_app" "devcontainer-app" {
agent_id = coder_devcontainer.dev.subagent_id
slug = "devcontainer-app"
}
resource "coder_script" "devcontainer-script" {
agent_id = coder_devcontainer.dev.subagent_id
display_name = "Devcontainer Script"
script = "echo hello"
run_on_start = true
}
resource "coder_env" "devcontainer-env" {
agent_id = coder_devcontainer.dev.subagent_id
name = "MY_VAR"
value = "my-value"
}Automated review via Coder Tasks |
DanielleMaywood
deleted the
danielle/devcontainer-resources/provisioner
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#1239
Allow associating
coder_env,coder_scriptandcoder_appwithcoder_devcontainerresource. To do this we make use of the newly addedsubagent_idfield in thecoder_devcontainerresource added in coder/terraform-provider-coder#474