fix: show explicit schedule stop time#2171
Merged
greyscaled merged 2 commits intomainfrom Jun 8, 2022
Merged
Conversation
This does not fully resolve all requests in #2141, but just the piece of when the workspace is actually stopping. Next, we will adjust the default extension from 90 minutes to 4 hours. Lastly, we can look at customizing the extension time in the extension flow or with a pre-emptive prompt next to the stop time.
greyscaled
commented
Jun 8, 2022
| } else { | ||
| return "Manual" | ||
| } | ||
| return "Manual" |
Contributor
Author
There was a problem hiding this comment.
Review:
Just meeting the FE code convention of using explicit else here.
greyscaled
commented
Jun 8, 2022
| import advancedFormat from "dayjs/plugin/advancedFormat" | ||
| import duration from "dayjs/plugin/duration" | ||
| import relativeTime from "dayjs/plugin/relativeTime" | ||
| import timezone from "dayjs/plugin/timezone" |
Contributor
Author
There was a problem hiding this comment.
Review:
Both are needed to manipulate time in the user's timezone and display timezone information (specifically where you see .format("z")
johnstcn
approved these changes
Jun 8, 2022
greyscaled
added a commit
that referenced
this pull request
Jun 8, 2022
greyscaled
added a commit
that referenced
this pull request
Jun 8, 2022
Summary: Uncaught from the change in #2171
greyscaled
added a commit
that referenced
this pull request
Jun 9, 2022
Summary: Uncaught from the change in #2171
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
This does not fully resolve all requests in #2141, but just the piece of when the workspace is actually stopping. Next, we will adjust the default extension from 90 minutes to 4 hours. Lastly, we can look at customizing the extension time in the extension flow or with a pre-emptive prompt next to the stop time.
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
Summary: Uncaught from the change in #2171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not fully resolve all requests in #2141, but just the piece of
when the workspace is actually stopping.
Next, we will adjust the default extension from 90 minutes to 4 hours.
Lastly, we can look at customizing the extension time in the extension
flow or with a pre-emptive prompt next to the stop time.