Skip to content

fix: increase default extension time#2172

Merged
greyscaled merged 2 commits intomainfrom
vapurrmaid/gh-2141/default-extension-time
Jun 8, 2022
Merged

fix: increase default extension time#2172
greyscaled merged 2 commits intomainfrom
vapurrmaid/gh-2141/default-extension-time

Conversation

@greyscaled
Copy link
Contributor

This does not fully close #2141, but builds upon #2171 to fulfill each
of the UX requests.

A next step (probably as a separate ticket) is to allow customizing
extension time pre-emptively.

This does not fully close #2141, but builds upon #2171 to fulfill each
of the UX requests.

A next step (probably as a separate ticket) is to allow customizing
extension time pre-emptively.
@greyscaled greyscaled requested a review from johnstcn June 8, 2022 15:36
@greyscaled greyscaled requested a review from a team as a code owner June 8, 2022 15:36
"2022-06-02T14:56:34Z",
{
deadline: "2022-06-02T16:26:34Z",
deadline: "2022-06-02T18:56:34Z",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review:

It was previously 90 minutes, now it's 4 hours. So this adds 2.5 hours.

"2022-06-02T10:56:20-04:00",
{
deadline: "2022-06-02T16:26:20Z",
deadline: "2022-06-02T18:56:20Z",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review:

It was previously 90 minutes, now it's 4 hours. So this adds 2.5 hours.

@greyscaled greyscaled merged commit b390250 into main Jun 8, 2022
@greyscaled greyscaled deleted the vapurrmaid/gh-2141/default-extension-time branch June 8, 2022 16:00
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
This does not fully close #2141, but builds upon #2171 to fulfill each
of the UX requests.

A next step (probably as a separate ticket) is to allow customizing
extension time pre-emptively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shutdown extension in UI is too brief

2 participants