Merged
Conversation
56b41d4 to
4b27cb3
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
johnstcn
reviewed
Jan 30, 2026
Member
johnstcn
left a comment
There was a problem hiding this comment.
I would argue that it's not strictly necessary to make a breaking change to the CLI output in this case. Users can still hit the API if they need to determine if it was a snapshot or not.
Member
Author
I guess that's fair. Most of the metadata is available via "warn"ing instead. We could even add the snapshot timestamp for good measure to the output. |
4b27cb3 to
b8bc11d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
b8bc11d to
04e0df8
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
7cfd7a5 to
9f11a56
Compare
34bcb99 to
1b92853
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
johnstcn
approved these changes
Jan 30, 2026
Member
johnstcn
left a comment
There was a problem hiding this comment.
I really need to fix that test :(
Base automatically changed from
mafredri/feat-coderd-return-log-snapshot-for-paused-task
to
main
January 30, 2026 14:09
The CLI now displays warnings when showing snapshot data based on task status and message count, detects missing snapshots via SnapshotAt nullability, and provides actionable guidance when no snapshot is available. JSON output format remains unchanged (still returns logs array). Warnings are shown on stderr while logs go to stdout. Closes coder/internal#1255
1b92853 to
438b390
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI displays warnings when showing snapshot data with task status
and message count, detects missing snapshots via SnapshotAt nullability,
and provides actionable guidance when no snapshot is available.
Closes coder/internal#1255