fix!: remove deprecated prometheus metrics#21788
Merged
Conversation
Removes the following deprecated Prometheus metrics: - coderd_api_workspace_latest_build_total (use coderd_api_workspace_latest_build instead) - coderd_oauth2_external_requests_rate_limit_total (use coderd_oauth2_external_requests_rate_limit instead) These metrics were deprecated in #12976 because gauge metrics should avoid the `_total` suffix per Prometheus naming conventions. Fixes #12999
Contributor
Documentation CheckUpdates Needed
Note: The metrics table in Automated review via Coder Tasks |
mtojek
changed the title
github-actions
bot
added
the
release/breaking
Contributor
Documentation CheckPrevious FeedbackPartially addressed - was removed successfully, but remains. Updates Still Needed
After removing these lines from Automated review via Coder Tasks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the following deprecated Prometheus metrics:
coderd_api_workspace_latest_build_total→ usecoderd_api_workspace_latest_buildinsteadcoderd_oauth2_external_requests_rate_limit_total→ usecoderd_oauth2_external_requests_rate_limitinsteadThese metrics were deprecated in #12976 because gauge metrics should avoid the
_totalsuffix per Prometheus naming conventions.Changes
coderd_api_workspace_latest_build_totalfromcoderd/prometheusmetrics/prometheusmetrics.gocoderd_oauth2_external_requests_rate_limit_totalfromcoderd/promoauth/oauth2.goFixes #12999