chore: extract coder bin handling to its own file#21916
Merged
spikecurtis merged 1 commit intomainfrom Feb 6, 2026
Merged
Conversation
Contributor
Author
This was referenced Feb 4, 2026
![coder-tasks[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/2652121?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
Reviewed the refactoring PR that extracts Coder binary handler code from site.go to a new bin.go file. This is a straightforward code movement with no logic changes.
✅ Approved - The refactoring is clean and follows good separation of concerns. The code has been moved exactly as described with no modifications to logic.
Summary
- Extracted binary handling functions to
site/bin.go - Removed unused imports from
site.go - All functions maintain identical behavior
- Package-level structure unchanged
Code Quality
- ✅ All functions moved correctly with no logic changes
- ✅ Imports properly updated in both files
- ✅ Comments and documentation preserved
- ✅ No breaking changes
- ✅ Follows Go file organization best practices
This refactoring improves code maintainability by reducing the size of site.go and grouping related binary handling functionality together, making future changes easier to implement.
No issues found.
spikecurtis
force-pushed
the
spike/internal-1300-refactor-site-bin
branch
2 times, most recently
from
1613bcb to
ac49605
Compare
spikecurtis
force-pushed
the
spike/internal-1300-cachecompress-pkg
branch
from
8eea2e0 to
05358a4
Compare
spikecurtis
force-pushed
the
spike/internal-1300-refactor-site-bin
branch
from
ac49605 to
f184efa
Compare
spikecurtis
force-pushed
the
spike/internal-1300-cachecompress-pkg
branch
from
05358a4 to
3a2606c
Compare
spikecurtis
force-pushed
the
spike/internal-1300-refactor-site-bin
branch
from
f184efa to
e838f7e
Compare
spikecurtis
force-pushed
the
spike/internal-1300-cachecompress-pkg
branch
from
3a2606c to
de03035
Compare
cstyan
approved these changes
Feb 4, 2026
spikecurtis
changed the base branch from
spike/internal-1300-cachecompress-pkg
to
graphite-base/21916
spikecurtis
force-pushed
the
spike/internal-1300-refactor-site-bin
branch
from
e838f7e to
678c91a
Compare
spikecurtis
force-pushed
the
graphite-base/21916
branch
from
de03035 to
8aa9e9a
Compare
spikecurtis
force-pushed
the
spike/internal-1300-refactor-site-bin
branch
from
678c91a to
a5bf33c
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to: coder/internal#1300
Refactors the site binary handler routines to their own file. The
site.gowas getting pretty long and I want to do some refactoring on how the binary handler works.This PR is literally just moving code from file to file; at the package level nothing is changed.