feat: add standard encodings to binary cache#21921
Merged
spikecurtis merged 1 commit intomainfrom Feb 6, 2026
Merged
Conversation
This was referenced Feb 4, 2026
Contributor
Author
![coder-tasks[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/2652121?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
Reviewed PR #21921 adding brotli and zstd compression to binary cache. Found 1 critical issue with closure variable capture in the loop.
Issues Found
🔴 CRITICAL: Closure variable capture bug in coderd/coderd.go - all encoders will use the last encoder from the map iteration
spikecurtis
force-pushed
the
spike/internal-1300-standard-encodings
branch
from
d6f4333 to
fc02705
Compare
spikecurtis
force-pushed
the
spike/internal-1300-bin-handler-uses-cachecompress
branch
from
8106a6c to
5c4a495
Compare
spikecurtis
force-pushed
the
spike/internal-1300-standard-encodings
branch
from
fc02705 to
c0af5d5
Compare
spikecurtis
force-pushed
the
spike/internal-1300-bin-handler-uses-cachecompress
branch
2 times, most recently
from
e33ee3d to
2a1bb80
Compare
spikecurtis
force-pushed
the
spike/internal-1300-standard-encodings
branch
from
c0af5d5 to
2ba6d56
Compare
cstyan
approved these changes
Feb 4, 2026
spikecurtis
force-pushed
the
spike/internal-1300-bin-handler-uses-cachecompress
branch
from
2a1bb80 to
e34610b
Compare
spikecurtis
force-pushed
the
spike/internal-1300-standard-encodings
branch
from
2ba6d56 to
7220f3a
Compare
spikecurtis
force-pushed
the
spike/internal-1300-bin-handler-uses-cachecompress
branch
from
e34610b to
7a87b89
Compare
spikecurtis
force-pushed
the
spike/internal-1300-standard-encodings
branch
from
7220f3a to
ca860de
Compare
spikecurtis
force-pushed
the
spike/internal-1300-bin-handler-uses-cachecompress
branch
from
7a87b89 to
df7270f
Compare
spikecurtis
force-pushed
the
spike/internal-1300-standard-encodings
branch
from
ca860de to
21e75c7
Compare
spikecurtis
force-pushed
the
spike/internal-1300-bin-handler-uses-cachecompress
branch
2 times, most recently
from
c01ae30 to
3f6e16d
Compare
spikecurtis
force-pushed
the
spike/internal-1300-standard-encodings
branch
from
21e75c7 to
352038c
Compare
spikecurtis
changed the base branch from
spike/internal-1300-bin-handler-uses-cachecompress
to
graphite-base/21921
spikecurtis
force-pushed
the
graphite-base/21921
branch
from
3f6e16d to
15885f8
Compare
spikecurtis
force-pushed
the
spike/internal-1300-standard-encodings
branch
from
352038c to
4deed54
Compare
spikecurtis
force-pushed
the
spike/internal-1300-standard-encodings
branch
from
4deed54 to
6cc6063
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: coder/internal#1300
Adds brotli and zstd compression to the binary cache. Also refactors coderd's streaming encoding middleware to use the same standard set of compression algorithms, so we have them in one place.