feat: add --client flag to list interceptions command#21951
Closed
pawbana wants to merge 3 commits intopb/aibridge-user-agent-recordingfrom
Closed
feat: add --client flag to list interceptions command#21951pawbana wants to merge 3 commits intopb/aibridge-user-agent-recordingfrom
pawbana wants to merge 3 commits intopb/aibridge-user-agent-recordingfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pawbana
force-pushed
the
pb/aibridge-user-agent-recording
branch
from
524db0c to
7c672c5
Compare
pawbana
force-pushed
the
pb/aibridge-user-agent-cli-flag
branch
2 times, most recently
from
301135c to
ea4184e
Compare
pawbana
force-pushed
the
pb/aibridge-user-agent-recording
branch
from
7c672c5 to
63f0a27
Compare
pawbana
force-pushed
the
pb/aibridge-user-agent-cli-flag
branch
from
ea4184e to
9a23b1c
Compare
pawbana
force-pushed
the
pb/aibridge-user-agent-recording
branch
from
63f0a27 to
3d8e453
Compare
pawbana
force-pushed
the
pb/aibridge-user-agent-cli-flag
branch
from
9a23b1c to
fe9202a
Compare
pawbana
force-pushed
the
pb/aibridge-user-agent-recording
branch
from
3d8e453 to
670801f
Compare
dannykopping
approved these changes
Feb 17, 2026
Contributor
dannykopping
left a comment
dannykopping
left a comment
There was a problem hiding this comment.
LGTM with minor notes
| }, | ||
| Handler: func(inv *serpent.Invocation) error { | ||
| client, err := r.InitClient(inv) | ||
| serpetClient, err := r.InitClient(inv) |
Contributor
There was a problem hiding this comment.
Nit
Suggested change
| serpetClient, err := r.InitClient(inv) | |
| apiClient, err := r.InitClient(inv) |
| Flag: "client", | ||
| Description: `Only return interceptions from this client.`, | ||
| Default: "", | ||
| Value: serpent.StringOf(&client), |
Contributor
There was a problem hiding this comment.
We should probably support multiple clients, but that can be implemented in a follow-up.
| <summary>Possible <code>client</code> values</summary> | ||
|
|
||
| > [!NOTE] | ||
| > AI tools are not setting user agent reliably. Client classification is done on best effort basis. |
Contributor
There was a problem hiding this comment.
Suggested change
| > AI tools are not setting user agent reliably. Client classification is done on best effort basis. | |
| > Client classification is done on best effort basis using the `User-Agent` header; not all clients send these headers in an easily-identifiable manner. |
Comment on lines
+35
to
+43
| - `Claude Code` | ||
| - `Codex` | ||
| - `Zed` | ||
| - `GitHub Copilot (VS Code)` | ||
| - `GitHub Copilot (CLI)` | ||
| - `Kilo Code` | ||
| - `Roo Code` | ||
| - `Cursor` | ||
| - `Unknown` |
Contributor
There was a problem hiding this comment.
I'm a little worried about this list going stale.
Contributor
Documentation CheckUpdates Needed
Note The monitoring.md documentation comprehensively documents the Automated review via Coder Tasks |
Contributor
Author
|
Merged in: #21839 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.