Skip to content

feat: remove agent workspaces limit#21998

Merged
jakehwll merged 25 commits intomainfrom
jakehwll/1281-remove-agent-workspaces-limit
Feb 20, 2026
Merged

feat: remove agent workspaces limit#21998
jakehwll merged 25 commits intomainfrom
jakehwll/1281-remove-agent-workspaces-limit

Conversation

@jakehwll
Copy link
Contributor

@jakehwll jakehwll commented Feb 9, 2026

In relation to internal#1281

Managed agent workspace build limits are now advisory only. Breaching the limit no longer blocks workspace creation — it only surfaces a warning.

  • Removed hard-limit enforcement in checkAIBuildUsage so AI task builds are always permitted regardless of managed agent count.
  • Updated the license warning to remove "Further managed agent builds will be blocked." verbiage.
  • Updated tests to assert builds succeed beyond the limit instead of failing.
  • Removed the "Limit" display from the ManagedAgentsConsumption progress bar — the bar is now relative to the included allowance (soft limit) only, and turns orange when usage exceeds it.

Bonus:

  • De-MUI'd LicenseBannerView — replaced Emotion CSS and MUI Link with Tailwind classes.
  • Added highlight-orange color token to the Tailwind theme.

Copy link
Contributor Author

jakehwll commented Feb 11, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jakehwll jakehwll marked this pull request as ready for review February 11, 2026 08:48
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b1113a2d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const usagePercentage = Math.min((usage / limit) * 100, 100);
const includedPercentage = Math.min((included / limit) * 100, 100);
const remainingPercentage = Math.max(100 - includedPercentage, 0);
const usagePercentage = Math.min((usage / included) * 100, 100);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Guard against zero included allowance in usage percentage

The new usagePercentage formula divides by included, but soft_limit can legitimately be 0 (for licenses with no included allowance). In that case, usage=0 yields NaN, which is then passed to style.width as NaN%, so the progress bar renders incorrectly and is treated as exceeded (NaN < 100 is false). Please handle included === 0 explicitly before computing the percentage.

Useful? React with 👍 / 👎.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being fixed in a follow-up PR, #22048

Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend ✅

@jakehwll jakehwll requested a review from jaaydenh February 11, 2026 15:29
Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coder-tasks
Copy link
Contributor

coder-tasks bot commented Feb 16, 2026

Documentation Check

Updates Needed

  • docs/ai-coder/ai-governance.md - Update section "Agent Workspace Build Limits" (lines 131-145) to clarify that limits are advisory only and do not block workspace creation

    • Already accurate: Line 143 explicitly states "Coder Tasks and other AI features continue to function normally even if the limit is breached"
    • No blocking language: Documentation correctly describes warning-only enforcement (line 144)
  • docs/ai-coder/ai-governance.md - Update the warning message reference (line 144) to match the new warning text

    • Not applicable: Documentation doesn't quote the specific warning text, only describes the behavior

Analysis

This PR changes managed agent limits from hard enforcement to soft enforcement (advisory warnings only). After reviewing the current documentation:

✅ Documentation is already accurate:

  • docs/ai-coder/ai-governance.md (lines 139-145) correctly states that features "continue to function normally even if the limit is breached"
  • No mention of blocking workspace creation - only warnings
  • Accurately describes the enforcement model

Minor consideration (optional enhancement):

  • docs/ai-coder/tasks.md uses the phrase "To scale beyond the 1,000 build limit" which could potentially be clarified to emphasize that exceeding the limit triggers warnings (not blocking), but this is already implied by the ai-governance.md documentation that states features continue to function normally

Conclusion: No documentation changes are required. The existing documentation already accurately reflects the advisory-only nature of managed agent limits.


Automated review via Coder Tasks

@jakehwll jakehwll merged commit 2038997 into main Feb 20, 2026
31 checks passed
@jakehwll jakehwll deleted the jakehwll/1281-remove-agent-workspaces-limit branch February 20, 2026 01:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants