Skip to content

chore: update Go from 1.25.6 to 1.25.7#22042

Merged
sreya merged 2 commits intomainfrom
jon/go126
Feb 18, 2026
Merged

chore: update Go from 1.25.6 to 1.25.7#22042
sreya merged 2 commits intomainfrom
jon/go126

Conversation

@sreya
Copy link
Collaborator

@sreya sreya commented Feb 10, 2026 •
edited
Loading

update Go from 1.25.6 to 1.25.7

@sreya sreya requested a review from deansheather February 10, 2026 22:06
jdomeracki-coder
jdomeracki-coder approved these changes Feb 11, 2026
View reviewed changes
Copy link
Contributor

@jdomeracki-coder jdomeracki-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matifali
Copy link
Member

matifali commented Feb 16, 2026 •
edited
Loading

Running make fmt|lint|gen should fix CI. It is a badly formatted Markdown table.

@sreya sreya force-pushed the jon/go126 branch 2 times, most recently from 605cfe2 to 3b6366d Compare February 17, 2026 00:37
@coder-tasks
Copy link
Contributor

coder-tasks bot commented Feb 17, 2026 •
edited
Loading

Documentation Check

Updates Needed

  • docs/reference/api/schemas.md - Fix badly formatted markdown table for url.URL schema (rows: rawFragment, rawPath, rawQuery, scheme, user)
    • Missing spaces between pipe characters
    • Newlines breaking table format
    • (Resolved: PR was updated to target Go 1.25.7 instead of 1.26.0; table formatting in schemas.md is now correct)

Notes

This is a Go patch version bump (1.25.6 → 1.25.7). No user-facing or API changes. No documentation updates needed.

Automated review via Coder Tasks

@sreya sreya force-pushed the jon/go126 branch 3 times, most recently from c185c4b to d2c602e Compare February 18, 2026 01:23
@sreya sreya requested a review from aslilac as a code owner February 18, 2026 01:23
sreya added 2 commits February 18, 2026 01:25
@sreya
chore: update Go from 1.25.6 to 1.25.7
1f1fac2
@sreya
fix(testutil): use /tmp for unix socket tests on Linux
0c646f2 
On GitHub Actions runners, TMPDIR is set to a long path like
/home/runner/work/_temp/go-tmp/. Combined with long test names, this
exceeds Linux's 108-byte sun_path limit for unix sockets, causing
'bind: invalid argument' failures.

Previously, TempDirUnixSocket only used /tmp on macOS. Now it uses /tmp
on all non-Windows platforms (Linux, macOS, BSDs), falling back to
t.TempDir() only on Windows where unix socket path limits don't apply.
@sreya sreya changed the title chore: update Go from 1.25.6 to 1.26.0 chore: update Go from 1.25.6 to 1.25.7 Feb 18, 2026
@sreya sreya removed the request for review from aslilac February 18, 2026 02:23
@sreya
Copy link
Collaborator Author

sreya commented Feb 18, 2026 •
edited
Loading

I got a spooky error related to the runtime when I tried to go to 1.26 so I'm just going to leave us on 1.25 for now

2026-02-17T23:14:30.9620582Z unexpected fault address 0x106cdf6dda
2026-02-17T23:14:30.9620716Z fatal error: fault
2026-02-17T23:14:30.9620914Z [signal 0xc0000005 code=0x1 addr=0x106cdf6dda pc=0x7ff6cae435e7]
2026-02-17T23:14:30.9620996Z 
2026-02-17T23:14:30.9621193Z goroutine 2716 gp=0x27e56cdf6d20 m=43 mp=0x27e56c409008 [running]:
2026-02-17T23:14:30.9621571Z runtime.throw({0x7ff6ccaf18d5?, 0x7ff6cae43bf9?})
2026-02-17T23:14:30.9622094Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/runtime/panic.go:1229 +0x4d fp=0x27e56cecf5e0 sp=0x27e56cecf5b0 pc=0x7ff6cae9d42d
2026-02-17T23:14:30.9622235Z runtime.sigpanic()
2026-02-17T23:14:30.9622765Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/runtime/signal_windows.go:398 +0xd0 fp=0x27e56cecf628 sp=0x27e56cecf5e0 pc=0x7ff6cae7cfb0
2026-02-17T23:14:30.9623208Z runtime.gcAssistAlloc(0x106cdf6d20)
2026-02-17T23:14:30.9623720Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/runtime/mgcmark.go:696 +0x447 fp=0x27e56cecf6b8 sp=0x27e56cecf628 pc=0x7ff6cae435e7
2026-02-17T23:14:30.9623880Z runtime.deductAssistCredit(0x27e56cecf7b8?)
2026-02-17T23:14:30.9624379Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/runtime/malloc.go:1913 +0x46 fp=0x27e56cecf6d8 sp=0x27e56cecf6b8 pc=0x7ff6cae34926
2026-02-17T23:14:30.9624530Z runtime.mallocgc(0x64, 0x0, 0x0)
2026-02-17T23:14:30.9625249Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/runtime/malloc.go:1165 +0x67 fp=0x27e56cecf708 sp=0x27e56cecf6d8 pc=0x7ff6cae9ab27
2026-02-17T23:14:30.9625379Z runtime.rawstring(...)
2026-02-17T23:14:30.9625714Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/runtime/string.go:325
2026-02-17T23:14:30.9625870Z runtime.rawstringtmp(0x27e56e3b9780?, 0x64)
2026-02-17T23:14:30.9626353Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/runtime/string.go:189 +0x3e fp=0x27e56cecf730 sp=0x27e56cecf708 pc=0x7ff6cae822be
2026-02-17T23:14:30.9626801Z runtime.concatstrings(0x7ff6cc453200?, {0x27e56cecf7c0?, 0x2, 0x7ff6cc6d3720?})
2026-02-17T23:14:30.9627303Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/runtime/string.go:54 +0xe5 fp=0x27e56cecf7a0 sp=0x27e56cecf730 pc=0x7ff6cae81825
2026-02-17T23:14:30.9627618Z runtime.concatstring2(0x27e56bbe3200?, {0x27e56cb42bd0?, 0x7ff6ccf84560?}, {0x27e56c6380c0?, 0x7ff6ccaf17b8?})
2026-02-17T23:14:30.9628099Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/runtime/string.go:66 +0x3e fp=0x27e56cecf7f0 sp=0x27e56cecf7a0 pc=0x7ff6cae8197e
2026-02-17T23:14:30.9628509Z testing.(*common).log(0x27e56bbe3200, {0x27e56c638060?, 0x1?})
2026-02-17T23:14:30.9629020Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/testing/testing.go:1044 +0xce fp=0x27e56cecf880 sp=0x27e56cecf7f0 pc=0x7ff6caf88f6e
2026-02-17T23:14:30.9629222Z testing.(*common).Log(0x27e56bbe3200, {0x27e56ce8e340?, 0x59?, 0x0?})
2026-02-17T23:14:30.9629714Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/testing/testing.go:1189 +0x45 fp=0x27e56cecf8d8 sp=0x27e56cecf880 pc=0x7ff6caf8a085
2026-02-17T23:14:30.9630176Z cdr.dev/slog/v3/sloggers/slogtest.(*testSink).LogEntry(0x27e56be84000, {0x2d?, 0x42?}, {{0x4bc6e08, 0xee126ed00, 0x0}, 0x0, {0x7ff6ccb84983, 0x26}, {0x27e56bc60180, ...}, ...})
2026-02-17T23:14:30.9630824Z 	C:/actions-runner/_temp/go-mod-cache/cdr.dev/slog/[email protected]/sloggers/slogtest/t.go:111 +0x222 fp=0x27e56cecfa60 sp=0x27e56cecf8d8 pc=0x7ff6cc350fc2
2026-02-17T23:14:30.9631140Z cdr.dev/slog/v3.Logger.Log({{0x27e56b8a02d0, 0x1, 0x1}, 0x0, {0x27e56bc60180, 0x2, 0x2}, {0x0, 0x0, 0x0}, ...}, ...)
2026-02-17T23:14:30.9631586Z 	C:/actions-runner/_temp/go-mod-cache/cdr.dev/slog/[email protected]/slog.go:47 +0x430 fp=0x27e56cecfbe8 sp=0x27e56cecfa60 pc=0x7ff6cb3d2ab0
2026-02-17T23:14:30.9631880Z cdr.dev/slog/v3.Logger.log({{0x27e56b8a02d0, 0x1, 0x1}, 0x0, {0x27e56bc60180, 0x2, 0x2}, {0x0, 0x0, 0x0}, ...}, ...)
2026-02-17T23:14:30.9632473Z 	C:/actions-runner/_temp/go-mod-cache/cdr.dev/slog/[email protected]/slog.go:160 +0x185 fp=0x27e56cecfe28 sp=0x27e56cecfbe8 pc=0x7ff6cb3d3ca5
2026-02-17T23:14:30.9632629Z cdr.dev/slog/v3.Logger.Debug(...)
2026-02-17T23:14:30.9632855Z 	C:/actions-runner/_temp/go-mod-cache/cdr.dev/slog/[email protected]/slog.go:84
2026-02-17T23:14:30.9633071Z github.com/coder/coder/v2/tailnet.(*nodeUpdater).updateLoop(0x27e56c30a9a0)
2026-02-17T23:14:30.9633386Z 	C:/actions-runner/coder/coder/tailnet/node.go:66 +0x425 fp=0x27e56cecffc8 sp=0x27e56cecfe28 pc=0x7ff6cc12e9a5
2026-02-17T23:14:30.9633854Z github.com/coder/coder/v2/tailnet.newNodeUpdater.gowrap1()
2026-02-17T23:14:30.9634181Z 	C:/actions-runner/coder/coder/tailnet/node.go:111 +0x17 fp=0x27e56cecffe0 sp=0x27e56cecffc8 pc=0x7ff6cc12ee97
2026-02-17T23:14:30.9634309Z runtime.goexit({})
2026-02-17T23:14:30.9634796Z 	C:/actions-runner/_temp/go-mod-cache/golang.org/[email protected]/src/runtime/asm_amd64.s:1771 +0x1 fp=0x27e56cecffe8 sp=0x27e56cecffe0 pc=0x7ff6caea54c1
2026-02-17T23:14:30.9635237Z created by github.com/coder/coder/v2/tailnet.newNodeUpdater in goroutine 690
2026-02-17T23:14:30.9635429Z 	C:/actions-runner/coder/coder/tailnet/node.go:111 +0x205

@sreya sreya merged commit e82edf1 into main Feb 18, 2026
56 of 58 checks passed
@sreya sreya deleted the jon/go126 branch February 18, 2026 04:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@deansheather deansheather deansheather approved these changes

@jdomeracki-coder jdomeracki-coder jdomeracki-coder approved these changes

Assignees

@sreya sreya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sreya @matifali @deansheather @jdomeracki-coder