Conversation
… page for more information.` messaging
…coder/ai-governance")`
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jakehwll
changed the title
soft_limit to limitsoft_limit to limit
github-actions
bot
added
the
release/breaking
…wll/1281-remove-hard-soft-limit
jakehwll
changed the title
soft_limit to limitsoft_limit to limit
github-actions
bot
removed
the
release/breaking
![chatgpt-codex-connector[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2783f8b515
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
deansheather
left a comment
deansheather
left a comment
There was a problem hiding this comment.
IMO all of the now unused code should be removed from license.go:
- licenseForbiddenFeatures
- uncommittedUsageFeatures (and the commit loop)
And in the regular feature loop, we should just map from managed_agent_limit_soft to managed_agent_limit with a simple if statement at the top.
deansheather
left a comment
deansheather
left a comment
There was a problem hiding this comment.
Looks good but you should also update coderdenttest.go, which has references to the old _soft and _hard features still. You'll probably need to change the signature of ManagedAgentLimit as well as the places that call it (likely not that many)
|
@codex review |
2 participants
In relation to
internal#1281Remove the
soft_limitfield from theFeaturetype and simplify license limit handling. This change:soft_limitfield from the API and SDKlimitvalue in the UI and API