chore: replace Inter with Geist variable font#22060
Conversation
chrifro
left a comment
chrifro
left a comment
There was a problem hiding this comment.
I just updated the font in Coder Kit as well and suggest we make some slight adjustments to the weights
text-base: Geist Regular (before Inter Medium)
text-sm: Geist Regular (before Inter Medium)
text-xs: Geist Regular (before Inter Medium)
text-xs mono: Geist Medium (before DM mono regular)
Regular is 400, Medium 500 I think
|
@chrifro currently whether something is regular, medium, bold etc, is currently set directly in the component and is also not 100% consistent for xs, sm, base. Are you suggesting we make sure all usages of text-xs, text-sm, text-base and text-xs mono, always have the same weights? This may be a separate PR. |
Ah interesting. Okay that would be a different PR then. Wouldn't it be a lot more intuitive if the weights are pre-defined and are not a guessing game? text-xs, text-sm, text-base need to exist in semi-bold for headlines and regular for standard text 
|
|
@chrifro I actually made a change to make the font weight consistent in this PR, a separate PR will still be needed to clean up to redundant usages of font weight throughout the codebase. |
4 participants
No description provided.