feat: add support for agentsock on Windows#22171
Merged
spikecurtis merged 1 commit intomainfrom Feb 20, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
spikecurtis
requested review from
SasSwart and
mafredri
and removed request for
mafredri
spikecurtis
force-pushed
the
spike/21335-agentsock-windows
branch
2 times, most recently
from
6513c6a to
87bb4d8
Compare
spikecurtis
commented
Feb 18, 2026
| logger := slog.Make().Leveled(slog.LevelDebug) | ||
| server, err := agentsocket.NewServer(logger, agentsocket.WithPath(socketPath)) | ||
| require.NoError(t, err) | ||
| require.NoError(t, server.Close()) |
Contributor
Author
There was a problem hiding this comment.
This just dupes StartStop so I removed.
spikecurtis
force-pushed
the
spike/21335-agentsock-windows
branch
from
87bb4d8 to
ec9ff80
Compare
Contributor
Documentation CheckUpdates Needed
Automated review via Coder Tasks |
SasSwart
approved these changes
Feb 19, 2026
Contributor
SasSwart
left a comment
SasSwart
left a comment
There was a problem hiding this comment.
I've spent an hour or so looking into go-winio and named pipes to gather context for this Code review. Given what I've been able to read, this looks good!
spikecurtis
force-pushed
the
spike/21335-agentsock-windows
branch
from
ec9ff80 to
8928981
Compare
spikecurtis
force-pushed
the
spike/21335-agentsock-windows
branch
from
8928981 to
5531809
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #21335
Adds support for the agentsock and thus
coder exp synccommands on Windows. This support was initially missing.