feat(coderd): filter expired API tokens server-side#22263
Merged
Conversation
Moves expired token filtering from client-side to server-side by adding
an include_expired parameter to the GetAPIKeysByLoginType and
GetAPIKeysByUserID database queries. This is more efficient for large
deployments with many expired/short-lived tokens.
Changes:
- Add include_expired parameter to SQL queries using OR short-circuit
- Add include_expired query parameter to GET /users/{user}/keys/tokens
- Add IncludeExpired field to codersdk.TokensFilter
- Remove client-side filtering from CLI tokens list command
- Add TestTokensFilterExpired test
Fixes coder/internal#1357
- Fix Go formatting alignment in coderd/apikey.go - Add include_expired to frontend TokensFilter callers - Pass include_expired through hooks to API
Contributor
Documentation CheckUpdates Needed
New Documentation Needed
Automated review via Coder Tasks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves expired token filtering from client-side to server-side by adding an
include_expiredparameter to theGetAPIKeysByLoginTypeandGetAPIKeysByUserIDdatabase queries. This is more efficient for large deployments with many expired/short-lived tokens.Changes
include_expiredparameter to SQL queries usingORshort-circuitinclude_expiredquery parameter toGET /users/{user}/keys/tokensIncludeExpiredfield tocodersdk.TokensFiltertokens listcommandTestTokensFilterExpiredtestFixes coder/internal#1357