Skip to content

chore: prematurely refresh oidc token near expiry during workspace build#22502

Merged
Emyrk merged 5 commits intomainfrom
stevenmasley/expired_during_build
Mar 3, 2026
Merged

chore: prematurely refresh oidc token near expiry during workspace build#22502
Emyrk merged 5 commits intomainfrom
stevenmasley/expired_during_build

Conversation

@Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 2, 2026

Closes #22429

@Emyrk Emyrk requested a review from johnstcn March 2, 2026 18:37
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to drop a log when we make this assumption but it doesn't look like we have a logger handy. 10 minutes seems fine.

@Emyrk
Copy link
Member Author

Emyrk commented Mar 2, 2026

It might be good to drop a log when we make this assumption but it doesn't look like we have a logger handy. 10 minutes seems fine.

Added a log line

@Emyrk Emyrk enabled auto-merge (squash) March 3, 2026 16:36
@Emyrk Emyrk merged commit f49dea6 into main Mar 3, 2026
45 of 47 checks passed
@Emyrk Emyrk deleted the stevenmasley/expired_during_build branch March 3, 2026 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: — OIDC access token can expire during workspace bootstrap

2 participants