Skip to content

fix: filter sub-agents from build duration metric#22732

Merged
sreya merged 4 commits intomainfrom
workspacebuildmetrics
Mar 10, 2026
Merged

fix: filter sub-agents from build duration metric#22732
sreya merged 4 commits intomainfrom
workspacebuildmetrics

Conversation

@sreya
Copy link
Collaborator

@sreya sreya commented Mar 6, 2026

fixes #22696

@sreya sreya marked this pull request as ready for review March 9, 2026 22:21
@sreya sreya force-pushed the workspacebuildmetrics branch from 3770501 to d74cd4a Compare March 9, 2026 22:28
@sreya sreya changed the title Workspacebuildmetrics fix: filter sub-agents from build duration metric Mar 9, 2026
@sreya sreya force-pushed the workspacebuildmetrics branch 2 times, most recently from b1ea37e to b597bfb Compare March 9, 2026 22:37
@sreya sreya requested a review from dannykopping March 9, 2026 22:40
@sreya sreya force-pushed the workspacebuildmetrics branch from b597bfb to 85f73b4 Compare March 9, 2026 22:41
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just not sure what is job_id is needed for

@sreya sreya force-pushed the workspacebuildmetrics branch from 85f73b4 to 425415c Compare March 10, 2026 16:39
@sreya sreya force-pushed the workspacebuildmetrics branch from 425415c to 14e94f2 Compare March 10, 2026 16:54
@sreya sreya merged commit 22a87f6 into main Mar 10, 2026
24 checks passed
@sreya sreya deleted the workspacebuildmetrics branch March 10, 2026 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: coderd_template_workspace_build_duration_seconds emits inflated duplicate observation on devcontainer rebuild

2 participants