Metron talker patch:

Subject: [PATCH] Use image hash
---
Index: metron_talker/metron.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/metron_talker/metron.py b/metron_talker/metron.py
--- a/metron_talker/metron.py	(revision 4e0d5c134d65ac4aa908a1cbd45a71cc6846d2c7)
+++ b/metron_talker/metron.py	(date 1739233743602)
@@ -31,7 +31,7 @@
 
 import settngs
 from comicapi import utils
-from comicapi.genericmetadata import ComicSeries, GenericMetadata, MetadataOrigin
+from comicapi.genericmetadata import ComicSeries, GenericMetadata, MetadataOrigin, ImageHash
 from comicapi.issuestring import IssueString
 from comicapi.utils import LocationParseError, parse_url
 from comictalker import talker_utils
@@ -1022,7 +1022,8 @@
             elif series["year_began"]:
                 md.year = utils.xlate_int(series["year_began"])
 
-        md._cover_image = issue["image"]
+        # md._cover_image = issue["image"]
+        md._cover_image = ImageHash(Hash=int(issue["cover_hash"], 16), Kind="phash")
 
         if issue.get("alt_number"):
             md.alternate_number = issue["alt_number"]

I don't think it's going to be much more effort to put a cover_hashes and alt_covers_hashes into GenericMetadata and then it's all set up and ready to go into the future? (And also, the issue cover images are broken in the issue window which there isn't a real way around if the url has been replaced.)

Only real question is representation of the GM field: tuple[ImageHash] or {phash: <hash>, ahash: <hash>}?

I don't think it's going to be much more effort to put a cover_hashes and alt_covers_hashes into GenericMetadata and then it's all set up and ready to go into the future?

Lets keep it as is for now. We can look at other ways of doing it later

(And also, the issue cover images are broken in the issue window which there isn't a real way around if the url has been replaced.)

#730 (comment) should take care of any unexpected errors, they should already handle an empty url (or the metron talker shouldn't work there at all).

I don't think it's going to be much more effort to put a cover_hashes and alt_covers_hashes into GenericMetadata and then it's all set up and ready to go into the future?

Lets keep it as is for now. We can look at other ways of doing it later

I've added URL to ImageHash which seems like the simplest options atm and solves the problems.

If you're happy, the hard part next is making the tests :)

It's simpler to just explicitly ignore the ImageHash outside of the IssueIdentifier

I thought adding the URL to ImageHash covered all the bases and at a later date it could be used as a fallback if wanted. But I can see that not being wanted anyway.

Is there anything you want me to do with this?