Change failed image loading from logger exception to warning#734
Change failed image loading from logger exception to warning#734lordwelch merged 3 commits intocomictagger:developfrom
Conversation
|
I don't understand why you want this. This just changes what gets logged no functionality changes and now we don't get a stack trace |
|
The problem is it will try to load empty bytes. The proper fix then is probably to test for 0 bytes first? |
|
It doesn't crash CT out but you get the log as in #732 which to my mind, isn't a real exception. Should 0 bytes not get that far? It seems like a reasonable check to do though? |
|
Here I think it is an exception, callers should check that they are sending non empty bytes. You can put a check in to log it with a proper message but it should still be logged as an error |
|
Added the size to the logger message. Hopefully that should be enough to not go chasing ghosts. |
|
Instead put a check at the beginning to return early and log that an empty image was provided |
|
Ready for merge? |
Could also change to
debugorpassit?Fixes #732