Merged
Conversation
2c33b6d to
c42b7b3
Compare
c42b7b3 to
9192667
Compare
decentral1se
reviewed
Jan 2, 2017
ChangeLog.md
Outdated
| * `stack haddock` now shows index.html paths when documentation is alread up to | ||
| date. Resolved [#781](https://github.com/commercialhaskell/stack/issues/781) | ||
| * Respects the `custom-setup` field introduced in Cabal 1.24. This | ||
| supercedes any `explicit-setup-deps` setings in your `stack.yaml` |
src/Stack/Build/Execute.hs
Outdated
| getPackageArgs = | ||
| case (packageSetupDeps package, mdeps) of | ||
| -- The package is using the Cabal custom-setup | ||
| -- configuraiton introduced in Cabal 1.24. In |
Member
There was a problem hiding this comment.
s/configuraiton/configuration/g
3 tasks
|
Just what I need! This isn't out yet right? I have stack v1.3.2 and get: Curious, will this be in 1.3.3? Edit: I see from the commit it's for 1.4, cool |
Member
|
@metaleap, try The functionality is in HEAD. |
|
I would, had I not just found out about stack's |
Member
Ah! It would be cool but I already moved city. But send my regards! Good people. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
I'm still testing this in a more complex use case. However, the simple test case I devised was:
stack new fooModify the
Setup.hsfile to addimport Acme.MissilesAdd
acme-missiles-0.3as an extra-depAdd the following
custom-setupblock tofoo.cabal:Set
build-typetoCustomConfirm that without the patch, the package refuses to compile. With the patch, it compiles just fine.
@borsboom Maybe we can sync up later on adding this as an integration test case?