Add warning if Cabal mismatch detected.#2970
Merged
snoyberg merged 1 commit intocommercialhaskell:masterfrom Feb 20, 2017
decentral1se:add-warning
Merged
Add warning if Cabal mismatch detected.#2970snoyberg merged 1 commit intocommercialhaskell:masterfrom decentral1se:add-warning
snoyberg merged 1 commit intocommercialhaskell:masterfrom
decentral1se:add-warning
Conversation
Member
Author
|
Travis failure unrelated, it's failing on HEAD as well and I'm not quite sure what the error is all about ... |
|
@lwm Sorry for the delay; I'm actually having trouble reproducing the original failure mode, i.e. I keep just getting successful builds on my Windows workstation. I'll try on my work Mac and hopefully update today or tomorrow. |
Member
Author
Contributor
|
Was this closed intentionally? |
Member
Author
|
Nope! I must have closed this when messing around with stale branches on the web UI. |
Contributor
|
@lwm Can you rebase against newest master and see if Travis builds successfully? |
Member
Author
|
Just rebased ... let's see 👍 |
Member
Author
|
Great, all green. Thanks @snoyberg! |
Member
Author
|
Should I do something further with this or? Is #2928 (comment) enough? |
snoyberg
approved these changes
Feb 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following from #2928. I didn't test it. @conklech, could you grab this change and give it a run? I'm not really sure how to mismatch my Cabal and I don't think I want to ;)