Improve filtering of ghc messages#3127
Improve filtering of ghc messages#3127mgsloan merged 4 commits intocommercialhaskell:masterfrom sergv:improve-filtering-of-ghc-messages
Conversation
|
@sergv Thanks for working on this, I like the cleanups! Are these warnings sure to be spurious? Perhaps the filtering should only be done when we know we're using ghc 7.8? |
|
@mgsloan The warnings are only visible on windows x64 and are definitely uninteresting as they don't affect the executables produced. I agree that it's good idea to only filter them for ghc 7.8. I'll prepare a followup patch in this PR soon. |
|
@mgsloan I've rebased the branch and ensured that filtering happens only for ghcs below 7.10. |
Add enum to control TH stripping messages. Add enum to control conversion of paths to absolute.
|
@sergv Sorry for taking so long to get this merged! Will try to be more on it in the future. |
|
@mgsloan Thanks for merging it anyway! It's reassuring to know than PR will be merged at some point, even if not so quickly. |
👍 👍 👍 |
3 participants
I added stripping of linker warnings on ghc 7.8 on windows (x64 IIRC). I'm not sure how useful it would be in general going forwards, but it's really annoying when it occurs.
I also took liberty to improve
Stack.Build.Executemodule a bit by adding type signatures no non-obvious parts and by introducing (hopefully) descriptive enums instead of booleans.