When a cabal file can't be found, warn that extra-deps could be the problem too#3808
Merged
mgsloan merged 1 commit intocommercialhaskell:masterfrom Jan 25, 2018
Merged
Conversation
MaxGabriel
force-pushed
the
warnExtraDeps
branch
from
08ab452 to
8852ecf
Compare
…roblem too. * Also: slight refactor to use only `concat` instead of ++ in the error message * Also: mention that a package.yaml file would also be accepted * The code that throws this is only searching for a .cabal file, but it runs hpack on the directory immediately before that to generate a cabal file, so it's effectively looking for a package.yaml file as well Closes commercialhaskell#3806
MaxGabriel
force-pushed
the
warnExtraDeps
branch
from
8852ecf to
fa3ffbe
Compare
Contributor
|
LGTM, thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concatinstead of ++ in the error messageCloses #3806
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
I used
stack installto install my changes, then ran that executable: