Merged
Conversation
Without this change `stack repl` fails to load .o files when they come from a symbolic link
snoyberg
requested changes
Nov 19, 2018
Contributor
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
Can you also include a changelog entry explaining the bug fix this is accomplishing?
qrilka
force-pushed
the
fix-test-4270
branch
from
7117686 to
1ea6bc5
Compare
Contributor
Author
|
Fixed, added changelog |
snoyberg
requested changes
Nov 19, 2018
ChangeLog.md
Outdated
| [#4314](https://github.com/commercialhaskell/stack/pull/4314) | ||
| * Add `--cabal-files` flag to `stack ide targets` command. | ||
| * Don't download ghc when using `stack clean`. | ||
| * Support loading in GHCi definitions from symlinked C files. See |
Contributor
There was a problem hiding this comment.
Suggested change
| * Support loading in GHCi definitions from symlinked C files. See | |
| * Support loading in GHCi definitions from symlinked C files. Without this patch, Stack will try to find object files in the directory pointed to by symlinks, while GCC will produce the object files in the original directory. See |
| return $ if exists then [p] else [] | ||
| resolveCandidate dir = fmap maybeToList . resolveDirFile dir | ||
|
|
||
| resolveDirFile |
Contributor
There was a problem hiding this comment.
Please add a comment explaining that symlinks will not be followed.
Contributor
Author
|
Anything else here? |
snoyberg
approved these changes
Nov 19, 2018
Contributor
|
Good to merge after CI runs |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please include the following checklist in your PR:
This is a fix for a test
4270-files-order, the main point of it is in af36e04 other commits improve Stack integration tests a bit.Integration tests succeed locally.