Show warning about local-programs-path with spaces on windows when running scripts#5013
Merged
mattaudesse merged 4 commits intocommercialhaskell:masterfrom Aug 30, 2019
Merged
Conversation
jneira
changed the title
local-programs-path with spaces on windowslocal-programs-path with spaces on windows when running scripts
Co-Authored-By: David Baynard <[email protected]>
Contributor
Author
|
@dbaynard not sure about the best way to inform the user, but it seems that show the original value of |
mattaudesse
approved these changes
Aug 28, 2019
Member
mattaudesse
left a comment
mattaudesse
left a comment
There was a problem hiding this comment.
Thanks @jneira - looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please include the following checklist in your PR:
It seems that warn messages are not shown when running a script so the more straigthforward way is change the log level of the relevant message. Not sure it it could have a unwanted consequence.
It fixes #5001.
I've tested the change manually running a script to check the message is actually shown.