Merged
Conversation
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
jgsogo
suggested changes
Mar 17, 2020
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
czoido
approved these changes
Mar 18, 2020
jgsogo
approved these changes
Mar 18, 2020
jgsogo
left a comment
jgsogo
left a comment
There was a problem hiding this comment.
I haven't tested it using Windows (it was the original issue), but if the triagge-man says it works, go ahead!
|
Yes, I tested it under Windows overriding the |
Member
Author
|
Indeed is terrible testing it, you need to install, change Conan's requirements and run Conan. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
When removing read-only files (os.unlink) on Windows, the current behavior is raise an exception. To fix this situation, we need to add write permission to that file.
Related issue: conan-io/conan#6676
We should release a new tag after this PR, and of course, release it on pypi.org (automatic operation related to current version).
Also, Conan will require a new patch version, because we are using a specific version for patch-ng there: https://github.com/conan-io/conan/blob/1.23.0/conans/requirements.txt#L6