Conversation
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
couple comments.. nothing to do with your changes more the structure of the prior defined errors
| snapshotter, err := aufs.New(root) | ||
| if err != nil { | ||
| return nil, errors.Wrap(plugin.ErrSkipPlugin, err.Error()) | ||
| return nil, fmt.Errorf("%s: %w", err.Error(), plugin.ErrSkipPlugin) |
There was a problem hiding this comment.
accurate port... but it feels it feels like the wrap is backwards maybe it should read:
fmt.Errorf("%s: %w", plugin.ErrSkipPlugin.Error(), err)
There was a problem hiding this comment.
Apologies, I was wrong you had it right the first time with fmt.Errorf("%s: %w", err.Error(), plugin.ErrSkipPlugin
zouyee
force-pushed
the
replaceerror
branch
2 times, most recently
from
4eb5dd8 to
bd81a32
Compare
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage 56.46% 56.46%
=======================================
Files 1 1
Lines 232 232
=======================================
Hits 131 131
Misses 68 68
Partials 33 33
Continue to review full report at Codecov.
|
Signed-off-by: Zou Nengren <[email protected]>
zouyee
force-pushed
the
replaceerror
branch
from
bd81a32 to
9572f92
Compare
5 participants
replace
pkg/errorsSigned-off-by: Zou Nengren [email protected]