Merged
Conversation
dcantah
approved these changes
Apr 7, 2023
dcantah
reviewed
Apr 7, 2023
Functions readSingleFile and getPidValue are only used for two files: pids.current and pids.max. It is easier and more efficient to use getStatFileContentUint64 for the same purpose. Switch to getStatFileContentUint64, remove the unused code. Signed-off-by: Kir Kolyshkin <[email protected]>
Since all the values that we deal with are of the same type (uint64),
let's remove inteface{} and all those typecasts and accessor functions.
Signed-off-by: Kir Kolyshkin <[email protected]>
dcantah
reviewed
Apr 8, 2023
dcantah
approved these changes
Apr 8, 2023
manugupt1
approved these changes
Apr 8, 2023
dims
approved these changes
Apr 13, 2023
This was referenced Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see individual commit messages for details.
This should make #381 way simpler