systemd-239+ no longer allows delegate slice#53
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Sep 5, 2018
Merged
systemd-239+ no longer allows delegate slice#53crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 13.32% 13.29% -0.03%
==========================================
Files 23 23
Lines 4518 4528 +10
==========================================
Hits 602 602
- Misses 3800 3810 +10
Partials 116 116
Continue to review full report at Codecov.
|
|
@crosbymichael ptal. |
systemd.go
Outdated
| // We need to see if systemd can handle the delegate property | ||
| // Systemd will return an error if it cannot handle delegate regardless | ||
| // of its bool setting. | ||
| canDelegate := true |
Member
There was a problem hiding this comment.
can we move this to a sync.Once ?
baude
force-pushed
the
systemdslicedelegate
branch
from
25c651e to
c0d66a3
Compare
Contributor
Author
|
@crosbymichael is this what you had in mind ? |
systemd.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| var once sync.Once |
Member
There was a problem hiding this comment.
This should be declared at the package level but otherwise, looks good
Systemd no longer allows the setting of the Delegate property for cgroups. This patch is modeled after a runc commit 0e16bd9b53eb3c57ea6fe59fc6d9385c2edb9fd9 which corrects a similar situation for them. Signed-off-by: baude <[email protected]>
baude
force-pushed
the
systemdslicedelegate
branch
from
c0d66a3 to
15ed73c
Compare
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Systemd no longer allows the setting of the Delegate property for
cgroups. This patch is modeled after a runc commit 0e16bd9b53eb3c57ea6fe59fc6d9385c2edb9fd9
which corrects a similar situation for them.
Signed-off-by: baude [email protected]