Bugfix: can't write to cpuset cgroup#54
Merged
estesp merged 1 commit intocontainerd:masterfrom Sep 17, 2018
Merged
Conversation
Using linux resource in spec:
```
"resources": {
"cpu": {
"period": 100000,
"quota": 40000
},
...
}
```
In this case, `resources.CPU` != nil but `resources.CPU.Cpus` and `resources.CPU.Mems`
are empty strings, `cgroups` lib will write "" to cpuset.cpus and cpuset.mems in
Cpuset group, then no process can be written in this cgroup any more.
In this case, empty value means copying from parent but doesn't mean no CPU can
be used in this cgroup.
Signed-off-by: Wei Zhang <[email protected]>
Contributor
Author
|
Note that previous code |
Contributor
Author
|
ping @crosbymichael |
Member
|
LGTM |
Contributor
Author
|
Thank you @crosbymichael @estesp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using linux resource in spec:
In this case,
resources.CPU!= nil butresources.CPU.Cpusandresources.CPU.Memsare empty strings,
cgroupslib will write "" to cpuset.cpus and cpuset.mems inCpuset group, then no process can be written in this cgroup any more.
In this case, empty value means copying from parent but doesn't mean no CPU can
be used in this cgroup.
Signed-off-by: Wei Zhang [email protected]