Move linters-settings.exclude-dirs to issues.exclude-dirs in golangci-lint config#11399
Merged
mxpv merged 1 commit intocontainerd:mainfrom Feb 18, 2025
Merged
Move linters-settings.exclude-dirs to issues.exclude-dirs in golangci-lint config#11399mxpv merged 1 commit intocontainerd:mainfrom
linters-settings.exclude-dirs to issues.exclude-dirs in golangci-lint config#11399mxpv merged 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: Jin Dong <[email protected]>
dosubot
bot
added
the
area/github_actions
djdongjin
force-pushed
the
fix-golangci-lint
branch
from
45c9f38 to
480e103
Compare
Member
Author
|
I think we should cherrypick it release/2.0 since the release/1.7 has a similar issue. I made a separate PR (#11400) for it instead of cherrypick, because in 1.7 we're still using the deprecated |
Member
Author
|
cc @ktock |
djdongjin
changed the title
exclude-dirs to issues.exclude-dirslinters-settings.exclude-dirs to issues.exclude-dirs in golangci-lint config
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
Author
|
/retest |
mxpv
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new golangci-lint action upgrade enabled golangci-lint config verification (from release note in #11397):
That exposed a bug in our config where
issues.exclude-dirswas put aslinters-settings.exclude-dirsby accident:https://github.com/containerd/containerd/actions/runs/13380233408/job/37367383920?pr=11397
The change was initially introduced in #10188 which also mentioned
issues.exclude-dirsshould be the correct path: