[release/2.0] update to go 1.24.0 / go1.23.6#11401
[release/2.0] update to go 1.24.0 / go1.23.6#11401k8s-infra-cherrypick-robot wants to merge 2 commits intocontainerd:release/2.0from
Conversation
Signed-off-by: Akihiro Suda <[email protected]>
https://go.dev/doc/go1.24 Signed-off-by: Akihiro Suda <[email protected]>
|
Hi @k8s-infra-cherrypick-robot. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dosubot
bot
added
area/toolchain
|
/ok-to-test |
| name: Release | ||
|
|
||
| env: | ||
| GO_VERSION: "1.23.5" |
There was a problem hiding this comment.
I think we should use 1.23.6 instead of latest version for support release.
There was a problem hiding this comment.
Yes. 💯 I think this was a miss when we made 2.0 branch cut. In other release branches we stick to the older stable of golang for making the release.
|
/hold |
|
@fuweid Shouldnt we remove this also https://github.com/containerd/containerd/blob/main/core/mount/mount_idmapped_utils_linux_go122.go#L1, since we are not building on 1.22 anymore? |
We can remove that file as long as we update this line to go1.23. Line 3 in e7efb87 |
|
Succeeded by #11410 |
Its better to not remove it at this point then. Because we dont want to change the minimum version needed to build containerd immediately. |
6 participants
This is an automated cherry-pick of #11377
/assign akhilerm